ml-archive / nodes-php-backend

Nodes backend package
http://nodesagency.com
MIT License
11 stars 5 forks source link

UnauthorizedHttpException first argument should be a String #154

Closed ellalderton closed 4 years ago

ellalderton commented 4 years ago

In the authenticate method in the Nodes\Backend\Auth\Providers\Session.php the UnauthorizedHttpException first argument is null, but the first argument needs to be string.

class UnauthorizedHttpException extends HttpException
{
    /**
     * @param string     $challenge WWW-Authenticate challenge string
     * @param string     $message   The internal exception message
     * @param \Throwable $previous  The previous exception
     * @param int        $code      The internal exception code
     */
    public function __construct(string $challenge, string $message = null, \Throwable $previous = null, ?int $code = 0, array $headers = [])
    {
        $headers['WWW-Authenticate'] = $challenge;

        parent::__construct(401, $message, $previous, $headers, $code);
    }
}
sebastianlyserena commented 4 years ago

This should be resolved by #155