ml-energy / zeus

Deep Learning Energy Measurement and Optimization
https://ml.energy/zeus
Apache License 2.0
180 stars 24 forks source link

Statically check cutoff twice with the same PL value #4

Closed Rosie-m closed 1 year ago

Rosie-m commented 1 year ago

Is your feature request related to a problem? Please describe. Currently, we are doing a dynamic check for the problem that cutoff twice with the same PL value. This is due to the fact that in our implementation with a time-based profile window, the number of iterations one profile window take can be variable. If we can move to a static check, this exception can be detected earlier.

Describe the solution you'd like In #2, we will move to an iteration-based profile window. So, we can do a static check in the constructor of ZeusDataLoader by comparing the len(self) with self.warmup_iters + self.prof_iters.