search

ml-explore / mlx-examples

Examples in the MLX framework
MIT License
5.5k stars 791 forks source link

Add mypy to .pre-commit-config.yml #830

Closed wangkuiyi closed 3 weeks ago

wangkuiyi commented 3 weeks ago

Fix https://github.com/ml-explore/mlx-examples/issues/829

wangkuiyi commented 3 weeks ago

Ah. Circle CI calls pre-commit. So we have to fix all mypy errors before enabling mypy in pre-commit.

awni commented 3 weeks ago

Oh yes.. that might take some time :. I wonder if we could point it to a list of files to start and add more over time 🤔

wangkuiyi commented 3 weeks ago

Sure. I am making a list and will paste to https://github.com/ml-explore/mlx-examples/issues/829