search

ml-explore / mlx-examples

Examples in the MLX framework
MIT License
5.5k stars 791 forks source link

added docstring explanation for bertenbeddings class in model.py in… #840

Closed saul1310 closed 1 week ago

saul1310 commented 2 weeks ago

This change adds a docstring explanation for the class Bertembeddings inside of model.py inside of bert. This is my first open source commit and I hope this helps! Signed off by saul Ifshin saulifshin.cs@gmail.com

awni commented 1 week ago

Thanks for the contribution. I'm going to close this though as I don't think the docstring is adding much here to help someone understand the purpose of that class (beyond the name itself), and it's somewhat inconsistent to just have one in that class and nowhere else.

If you would like to contribute some documenation or otherwise feel free to do so or open an issue / discussion if you are unsure of what to add.