search

ml-explore / mlx-swift-examples

Examples using MLX Swift
MIT License
1.03k stars 110 forks source link

Broken, unneeded GzipSwift is blocking consumers of mlx-libraries #85

Closed DePasqualeOrg closed 4 months ago

DePasqualeOrg commented 4 months ago

The latest release of GzipSwift is broken due to typos in the package file (https://github.com/1024jp/GzipSwift/issues/65). This package is only consumed by the MNIST target of mlx-swift-examples. I'm using mlx-libraries from this repo in my app, and it's pulling in the broken GzipSwift, which isn't needed and is blocking me from building my app. It would be great if this dependency could be removed from mlx-libraries.

Perhaps it would be best to split mlx-libraries into a separate, minimal repo, to reduce overhead and complications for consumers of this package?

davidkoski commented 4 months ago

Splitting the examples repo is probably a larger task and I am not sure we want to go there yet. For this we can at least fix it by pinning it to a good release. We don't need the latest and greatest gzip integration.

DePasqualeOrg commented 4 months ago

I'm happy to take on splitting out mlx-libraries into a separate repo if you'd like. I've basically already done that in my own fork of this repo, and in the example apps it would just involve changing some references to the libraries. Doing this earlier rather than later would prevent disruptions to everyone who starts using mlx-libraries later on.