search

ml-explore / mlx

MLX: An array framework for Apple silicon
https://ml-explore.github.io/mlx/
MIT License
14.83k stars 845 forks source link

0.12.2 release was not completed #1071

Closed chenrui333 closed 1 week ago

chenrui333 commented 2 weeks ago

👋 it looks like 0.12.2 release was not completed, ie the github release did not get created as 0.12.0, raise this issue for some awareness. Thanks! 🙏

relates to https://github.com/Homebrew/homebrew-core/pull/170675

awni commented 2 weeks ago

Sorry, not following, did the brew release not complete because 0.12.2 is a "pre-release"?

chenrui333 commented 2 weeks ago

@awni some tag issue

image

Also looks like 0.12.1 tag is gone, any thoughts?

awni commented 2 weeks ago

Hmm, the 0.12.1 tag is still there https://github.com/ml-explore/mlx/releases/tag/v0.12.1

I'm still not really following the problem. Anything we can do on our side to fix?

chenrui333 commented 2 weeks ago

oh, just need to mark 0.12.2 release as latest release? (oh, can you point me to the doc about the pre-release -> latest release process)? Thanks!

awni commented 2 weeks ago

oh, just need to mark 0.12.2 release as latest release?

How does the brew update work? If we do a new tag on MLX github does it try to do an auto release?

(oh, can you point me to the doc about the pre-release -> latest release process)?

There is no doc on that :(

chenrui333 commented 1 week ago

we track the latest release and autobump it as batch processing.

chenrui333 commented 1 week ago

yeah, for now, I probably just need a latest tag (if I do a livecheck update, it would ask me to downgrade to 0.12.0)

left a comment about that too, https://github.com/Homebrew/homebrew-core/pull/170675#issuecomment-2095018955

awni commented 1 week ago

Ok I set 0.12.2 as the latest release. Let me know if that doesn't unblock the brew build and I will reopen this!