Closed dc-dc-dc closed 4 months ago
This looks good to me. I am not sure we want to build the example extension at every commit, haven't decided yet. @jagrit06 take a look when you time and approve.
I think having the examples be part of the test suite makes sense as it ensures that they don't get stale, and developers looking to build on them don't end up running into issues due to missing updates.
I'm ok with adding it to CircleCI for now. Nevertheless, this should still be viewed as an experimental feature, we may break compatibility with it in the future (in favor of alternative extension approaches). It's one reason we don't advertise it much in the docs.
rebased, but before merging can we do a quick ci run in this pr to resolve any issues with the ci test script if any?
Good idea - and yea I think I can push this as a branch to check that
CI is running on this branch https://github.com/ml-explore/mlx/tree/extension_ci
Yeah, seems like it’s an issue when installing using a virtual env. when installing globally it’s fine, might be that the install location in make doesn’t line up, will look into this
@awni can you run it again? I suspect it may be installing a version of mlx on pypi(without the fix) and causing the error. I set it to install from my fix branch for now to test
I will run it, but I see two options to move forward
Wdyt?
Will update the pyproject.toml to point to mlx-explore/mlx/main
as after the merge it should work. Then after the next release can point it back to pypi with a version requirement.
For now can omit from the CI tests and add it back when the extension api gets in a more defined state, like you mentioned its still experimental so don't want to enforce that its tests pass as it can change.
Thanks!!
Proposed changes
Updates extension example with new api, and fixes the build issues with json headers missing.
Also added the build example to ci, ideally should run ci test in this pr before committing to make sure its good.
Checklist
Put an
x
in the boxes that apply.pre-commit run --all-files
to format my code / installed pre-commit prior to committing changes