ml-in-barcelona / jsoo-react

js_of_ocaml bindings for ReactJS. Based on ReasonReact.
https://ml-in-barcelona.github.io/jsoo-react
MIT License
138 stars 19 forks source link

Investigate unmounting effects not running #15

Closed jchavarri closed 5 years ago

jchavarri commented 5 years ago

Thanks to @benschinn we have support for useEffect and useLayoutEffect 🎉

One thing that remains to investigate are the unmount effects, which don't see to be running at the moment.

This can be seen in this line

https://github.com/jchavarri/rroo/blob/cfd84885338f055c6e1285f586de2f51043bb8b8/bin/UseEffect.re#L20-L22

that does not appear in the console.

In order to "bridge" the returned value with the effect we would have to, from React.js file: