Open jchavarri opened 1 year ago
While publishing in opam repository, I realized calling dune runtest would fail because we weren't tracking the dependency in node_modules anywhere (it was assumed that npm install would be called manually).
dune runtest
node_modules
npm install
This PR adds this dependency inside dune itself by leveraging the recently added directory targets. ref: https://github.com/ocaml/dune/issues/6168.
The yarn.lock was removed as it would lead to permission issues:
yarn.lock
npm ERR! Error: EACCES: permission denied, open '/.../jsoo-react/_build/default/test/yarn.lock'
As there are barely any deps and we are already constraining to minor versions of them, we should be fine.
While publishing in opam repository, I realized calling
dune runtestwould fail because we weren't tracking the dependency innode_modulesanywhere (it was assumed thatnpm installwould be called manually).This PR adds this dependency inside dune itself by leveraging the recently added directory targets. ref: https://github.com/ocaml/dune/issues/6168.
The
yarn.lockwas removed as it would lead to permission issues:As there are barely any deps and we are already constraining to minor versions of them, we should be fine.