Eslint Config

[schinns]

Fixes #14. In reference to conversation with @jchavarri in PR https://github.com/jchavarri/rroo/pull/18:

A lightweight eslint config!

In lib directory run:

$ yarn lint

P.S.- sorry for the misspelled branch name meant to name it js-lint

[schinns]

@jchavarri hey thanks for the review! I pushed up some changes that addresses most things I think.

Now getting just one warning from lint. And it might actually be a bug.

It looks like value argument is unused: https://github.com/jchavarri/rroo/blob/master/lib/React.js#L71

[schinns]

@jchavarri should we use something like husky for linting on a pre commit hook?

[schinns]

Oops @jchavarri. I misunderstood your comment above and committed the esy.lock directory. should I remove it? 😬

[jchavarri]

should we use something like husky for linting on a pre commit hook?

@benschinn Husky is cool! Although, I would only add it if we run into linting issues pretty often, for now I'd feel inclined to keep things leaner, especially considering we'll have soon CI integration when #4 is done.

I misunderstood your comment above and committed the esy.lock directory. should I remove it?

Ah! yes please 🙏 There's no rush though, I can do it later otherwise :)

[schinns]

Husky is cool! Although, I would only add it if we run into linting issues pretty often, for now I'd feel inclined to keep things leaner, especially considering we'll have soon CI integration when #4 is done.

Sounds good!

Ah! yes please 🙏 There's no rush though, I can do it later otherwise :)

Done! https://github.com/jchavarri/rroo/pull/20/commits/e41bcf88a5c19de1855ab987015a3f125f6957bc

[jchavarri]

Thanks @benschinn ! ✨