Fix build for dune 2, esy 0.6 and lwt 5

ml-in-barcelona / jsoo-react

js_of_ocaml bindings for ReactJS. Based on ReasonReact.

https://ml-in-barcelona.github.io/jsoo-react

MIT License

138 stars 19 forks source link

Fix build for dune 2, esy 0.6 and lwt 5 #35

Closed jchavarri closed 4 years ago

jchavarri commented 4 years ago

Fixes #34.

Several things were failing:

Something in esy 0.6 changed that was interferring with the way jsoo runs git log from dune file. Fixed by following same approach than rehp.
lwt dep in jsoo needed an upper bound
dune had to be pinned to v1

tau-gamma commented 4 years ago

Could you explain why dune has to be pinned to v1? As I would like to use a dependency that requires dune v2.

jchavarri commented 4 years ago

I tried originally but found some issues where Dune could not find jsoo-react-esy library from the examples folder. Maybe it's just a matter of checking the changes in Dune 2 and applying them to the project, but I had no time to look into that yet.