ml-in-barcelona / jsoo-react

js_of_ocaml bindings for ReactJS. Based on ReasonReact.
https://ml-in-barcelona.github.io/jsoo-react
MIT License
138 stars 19 forks source link

CI: Update setup-ocaml to v2 #68

Closed jchavarri closed 2 years ago

jchavarri commented 2 years ago

What title says.

See related PR: https://github.com/ocaml/setup-ocaml/pull/66.

Biggest improvements are that windows caching actually works. Also, macOS build is fixed (it was failing for some reason as it was not able to find reason or other commands).

The downside is that dependencies builds are not cached, so ubuntu build takes now ~4min instead of ~1. But I still think it's worth it, as we simplify cache handling and support more platforms so full build takes shorter and is more reliable. Also, upgrades to new versions of setup-ocaml will be easier. See related issue for caching deps: https://github.com/ocaml/setup-ocaml/issues/159.