ml-in-barcelona / jsoo-react

js_of_ocaml bindings for ReactJS. Based on ReasonReact.
https://ml-in-barcelona.github.io/jsoo-react
MIT License
138 stars 19 forks source link

Remove filtering of undefined props passed to upper case components (except `key`) #83

Closed jchavarri closed 2 years ago

jchavarri commented 2 years ago

There's no need to filter optional props on uppercase components when calling createElement, they can (and should) be passed as is. This will allow to get rid of array->list->array conversion and filtering on each element creation call.

The only exception is key property, which is handled by React.

Questions: