Allow `string option` transformations for native elements

ml-in-barcelona / jsoo-react

js_of_ocaml bindings for ReactJS. Based on ReasonReact.

https://ml-in-barcelona.github.io/jsoo-react

MIT License

138 stars 19 forks source link

Allow `string option` transformations for native elements #92

Closed davesnx closed 2 years ago

davesnx commented 2 years ago

This PR fixes a remaining bug for optional parameters, from https://github.com/ml-in-barcelona/jsoo-react/issues/81#issuecomment-1002261158

Was introduced by https://github.com/ml-in-barcelona/jsoo-react/pull/84.

zbaylin commented 2 years ago

Just want to chime in and say thanks for this @davesnx ❤️! I bumped up against this when trying to create components that used input, i.e. wanting to only set value if a value for it is passed in above. Will be nice to have this in 🎉