search

ml-in-programming / ArchitectureReloaded

Design defects detection plugin for IntelliJ IDEA. Based on BasLeijdekkers/MetricsReloaded plugin.
Other
8 stars 3 forks source link

HAC is slow #160

Open ujohnny opened 6 years ago

ujohnny commented 6 years ago

for project with INFO [org.jetbrains.research.groups.ml_methods.algorithm.entity.EntitySearcher.prepareResult] - Generated 3965 class entities INFO [org.jetbrains.research.groups.ml_methods.algorithm.entity.EntitySearcher.prepareResult] - Generated 26501 method entities INFO [org.jetbrains.research.groups.ml_methods.algorithm.entity.EntitySearcher.prepareResult] - Generated 10850 field entities

HAC didnt finish in 1 hour on 8cores CPU when ARI did

Ivan-Veselov commented 6 years ago

The reason for this is that HAC computational time is O((methods + fields)^2) in worst case and it requires the same amount of memory.

RamSaw commented 6 years ago

@ujohnny what is the name of the project? Because it seems that execution time mostly depends on connectivity of the components and classes but not only on number of entities.

ujohnny commented 6 years ago

https://github.com/spring-projects/spring-framework.git

ujohnny commented 6 years ago

actually memory wasnt a concern in my case.

Ivan-Veselov commented 6 years ago

What do you mean by that? IDEA had 1G of additional RAM or something? I'm asking because it can consume almost all available RAM and then very often run GC and this causes performance problems.

ujohnny commented 6 years ago

i use default configuration and idea's window about low memory wasnt shown there.