search

ml-in-programming / ArchitectureReloaded

Design defects detection plugin for IntelliJ IDEA. Based on BasLeijdekkers/MetricsReloaded plugin.
Other
8 stars 3 forks source link

Extract metrics reloaded as a submodule #170

Closed RamSaw closed 5 years ago

RamSaw commented 5 years ago

@Snyssfx is it ready to be reviewed and merged or you still need to commit some changes? Seems like travis is unable to download MetricsReloaded.

Snyssfx commented 5 years ago

@RamSaw oops, didn't see that there is travis CI, wait a few minutes, I will try to fix it

Snyssfx commented 5 years ago

@RamSaw there it is. Change ssh to https url for submodule.

Snyssfx commented 5 years ago

As for commiting some changes, I added Readme.md to MetricsReloaded-gradle with instructions (for other projects) how to build submodule

RamSaw commented 5 years ago

@Snyssfx strange behavior for me: I've cloned it, opened in IDEA and when I ran gradle task "assemble" it failed because gradle haven't found MetricsReloaded code (same behavior when I do it all from console without IDEA). When I run "buildDependents" it works fine and then all gradle targets (assemble, check etc.) work fine. But as I understood travis runs "./gradlew assemble" and it works fine for travis. But I can't understand why. Do you have any ideas? Actually when I tried just to clone and just to run "./gradlew buildDependents" in console (without any use of IDEA) it failed because of unresolved references in MetricsReloaded (for example such error: "package org.jfree.chart.axis does not exist"). But if I run after that "assemble" it builds successfully. Seems strange to me. Actually what gradle tasks do you execute to build the project successfully? I think the best behavior will be the following: we just execute assemble and it builds successfully. Can we do so?

Snyssfx commented 5 years ago

@RamSaw as I know, it's one of git submodules limitations. After clonning, you should execute in bash git submodule update --init --recursive. If you check Travis logs, you will probably find this command after git clone ...

Snyssfx commented 5 years ago

@RamSaw well, in this commit I have added submoduleUpdate gradle task, but my attempts to link it to building process was rather unsuccessful :( You can launch it manually, however