Reduce number of lines of code in `CutoutViewIndicator`

ml-opensource / CutoutViewIndicator

Android indicator for ViewPagers and so forth

Apache License 2.0

21 stars 3 forks source link

Reduce number of lines of code in `CutoutViewIndicator` #55

Open Cliabhach opened 7 years ago

Cliabhach commented 7 years ago

As of cee0bc4db158, there are

501 lines of java code
357 lines of comments
98 blank lines in CutoutViewIndicator.java. This seems a bit much. Could we get it down to 400 lines of java code?

Cliabhach commented 7 years ago

Related to #56 .

Cliabhach commented 7 years ago

Pushing this back to 0.9.0

Cliabhach commented 7 years ago

Most of the removable lines of code are setters and getters. They're formulaic enough, right?

Cliabhach commented 5 years ago

I fear that the work of #76 and #79 will take up the v0.9.0 release...I'm going to push this and the other issues targeted at v0.9.0 to v0.9.1 instead.