ml-opensource / admin-panel-template-reactjs

25 stars 10 forks source link

Handle mock API #112

Closed mvn-binhnguyen-hn closed 2 years ago

mvn-binhnguyen-hn commented 3 years ago

Handle mock API

What are you adding?

Implement Clients screen as template screen
Implement mock API
Modify axios intercepter to convert API response to camelCase format

Breaking changes?

Related PR

yukinoda commented 3 years ago

@mvn-binhnguyen-hn cc: @jacksonjp Good feature, let's discuss if we want this in the template or not at the meeting :)

yukinoda commented 3 years ago

@mvn-binhnguyen-hn brought this about the mock adapter a little bit to this discussion https://github.com/monstar-lab-oss/admin-panel-template-reactjs/discussions/107#discussioncomment-1199260

yukinoda commented 3 years ago

@jacksonjp @geekonthemove cc: @mvn-binhnguyen-hn I guess we can move the mock api related part to separate folder where the user can just remove it if is not going to be used?

@mvn-binhnguyen-hn if adding the mock api, I think we need some documentation to let the user know that is an optional feature that can be removed by just deleting the folder.

mvn-binhnguyen-hn commented 2 years ago

@jacksonjp

- Implement mock API
- Modify axios intercepter to convert API response to camelCase format

Both above implementations seem not necessary for the admin panel template, it depends on which project the template will be used, so should we ignore and close this PR?

jacksonjp commented 2 years ago

@mvn-binhnguyen-hn Yea i think lets close this PR

mvn-binhnguyen-hn commented 2 years ago

@mvn-binhnguyen-hn Yea i think lets close this PR

@jacksonjp Okay, I closed this PR. thanks 👍