search

ml-research / liground

A free, open-source and modern Chess Variant Analysis GUI for the 21st century
https://ml-research.github.io/liground.github.io/
GNU Affero General Public License v3.0
110 stars 35 forks source link

Bugs/improvements #172

Open cjssh1002 opened 3 years ago

cjssh1002 commented 3 years ago

I am a Janggi player. Bugs/improvements (used Windows 10 64bit)

  1. The pieces image has been changed. janggi has a different image from xiangqi. The currently implemented piece color (red) moves first, but in janggi, the blue piece must start moving first. So you have to sort the janggi group and the xiangqi group, or modify the blue colored piece to start first move. (The Blue Pieces should be located at the bottom and be able to move first.)

2.janggi/janggicasual/janggitraditional/janggimodern There are 4 types of rules. We hope to support all four types of rules.

  1. When running janggi on Winboard/xBoard, use the CECP protocol. Currently, Riground uses the UCI protocol. (Add support for moving coordinates) So the starting rank is different. UCI starts at rank 1, but CECP starts at rank 0. So the PGN is not compatible. Separate the coordinates or ask for support to run in CECP mode.

  2. FEN compatibility recognition problem [ex. v->add_piece(JANGGI_ELEPHANT,'b','e');] rhea1aehr/4k4/1c5c1/p1p1p1p1p/9/9/P1P1P1P1P/1C5C1/4K4/RHEA1AEHR w 0 1 (Winboard/Xboard) rnba1abnr/4k4/1c5c1/p1p1p1p1p/9/9/P1P1P1P1P/1C5C1/4K4/RNBA1ABNR w - - 0 1 (Riground)

Ask them to be able to recognize the following pieces as well. n/N = h/H b/B = e/E w - - 0 1 = w 0 1

  1. Last Part of the content of the PGN may be in Korean. Currently, the Korean language is not display written (korean is broken). This seems like an encoding problem. Can display Korean language?(PGN inf) Polyglot openingbook support add. We also need to game human vs. engine.
QueensGambit commented 3 years ago

Thank you @cjssh1002 for raising these issues.

  1. Is a bug and could be fixed within LiGround.
  2. This could be added ffish.js / FairyStockfish for LiGround to support it.
  3. & 4. These are related to ffish.js / FairyStockfish as well.
  4. Allowing different languages when loading PGNs sounds good.

If you want directly start to fix some of these issues yourself, feel free to create a pull request. The group project is now officially over and anyone can freely contribute now.