search

ml-starter-packs / ml-monorepo

Educational example monorepo demonstrating services managed with pants.
https://ml-starter-packs.github.io/ml-monorepo/
MIT License
0 stars 0 forks source link

Add resizing and tracking #5

Closed sarodz closed 2 years ago

mathematicalmichael commented 2 years ago

I'm glad the images aren't part of this PR, but I think we should have some method that goes and downloads images (perhaps of imgur or perhaps s3 or perhaps public apache server) and saves them in a way that these tests expect.

we can accomplish this with a shell script for now or makefile, but eventually some method that is actually responsible will be called to go download test files if need be during runtime (much like you download model files to /tmp/ or something like that when you use tensorflow-hub).

sarodz commented 2 years ago

I like the changes you have made, I committed them as is. I will test this code at my end once they pass, I'll merge.

As to your comment, I have the same vision but I am planning to add the scripts once the backend is live.