search

ml-tooling / contaxy

MIT License
10 stars 8 forks source link

Bugfix: Fix SSL nginx configuration #14

Closed JNKielmann closed 3 years ago

JNKielmann commented 3 years ago

The nginx configuration and entrypoin.sh script had some small errors that resulted in an error on startup when ssl was enabled.

This PR fixes these errors by taking the old ML Lab nginx configuration as reference.

raethlein commented 3 years ago

Hey @JNKielmann, thanks for fixing it! Looks good to me. Did you test it locally? And the build process does not run through, there seems to be a problem with the openjdk package which we should fix.

JNKielmann commented 3 years ago

Hi @raethlein In our private branch we tested this together with some other changes locally and on a remote server. Once the open PRs are merged I would release a new version of the contaxy library and do some testing again.

For the error in the build pipeline I would open a separate issue + PR.

lukasmasuch commented 3 years ago

This looks good for me as well 👍 Feel free to merge the PRs into main as soon as the build pipeline is running. Do you already have a fix for the build pipeline, otherwise I can take a look on that.