search

ml-tooling / contaxy

MIT License
10 stars 8 forks source link

Allow to pass metadata on file upload #80

Closed NaveenKinnal closed 2 years ago

NaveenKinnal commented 2 years ago

With the commit, we worked the following changes:

  1. Ability to store the metadata during file upload - Now, instead of the corresponding minio S3 bucket storing the metadata, we store it as a Dict in its corresponding Postgre Database entry.
lgtm-com[bot] commented 2 years ago

This pull request introduces 4 alerts when merging 43c49e9de44329cae838e6f259b88dfc9b19a996 into 2530cda755deba54c2df5d2292d088a58ff0c1b3 - view on LGTM.com

new alerts:

JNKielmann commented 2 years ago

Hi @NaveenKinnal,

I checked the code and overall it looks good. There were a few issues that I have fixed in a separate commit (https://github.com/ml-tooling/contaxy/pull/80/commits/b6a7a889dde70e3b8c9d851e87aca055d00ea8fc). Next time when you are working on the contaxy backend, make sure to execute the linting before submitting the PR. For that you need to run python build.py --check from the backend folder.