JNKielmann
commented
2 years ago There are some linting errors in the pipeline:
src/contaxy/managers/project.py:220: error: Return type "List[UserPermission]" of "list_project_members" incompatible with return type "List[User]" in supertype "ProjectOperations"
src/contaxy/managers/project.py:298: error: Incompatible return value type (got "List[UserPermission]", expected "List[User]")
src/contaxy/managers/project.py:298: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
src/contaxy/managers/project.py:298: note: Consider using "Sequence" instead, which is covariant
src/contaxy/managers/project.py:312: error: Incompatible return value type (got "List[UserPermission]", expected "List[User]")
src/contaxy/managers/project.py:312: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
src/contaxy/managers/project.py:312: note: Consider using "Sequence" instead, which is covariant
src/contaxy/managers/auth.py:839: error: Argument 1 to "append" of "list" has incompatible type "UserRead"; expected "User"
Found 5 errors in 3 files (checked 78 source files)
Executing: pipenv run flake8 --show-source --statistics src
src/contaxy/api/endpoints/user.py:47:5: F841 local variable 'e' is assigned to but never used
except Exception as e:
^
src/contaxy/api/endpoints/user.py:55:5: F841 local variable 'e' is assigned to but never used
except Exception as e:
^
2 F841 local variable 'e' is assigned to but never usedYou can run the linting step locally by executing python build.py --check in the backend folder.
The mypy errors are due to changes in the manager classes which are not reflected in the respective base interfaces.
lgtm-com[bot]
provide user list response based on user privileges