ml-tooling / ml-hub

🧰 Multi-user development platform for machine learning teams. Simple to setup within minutes.
Apache License 2.0
301 stars 64 forks source link

upgrade to adopt the latest jupyterhub feature #25

Open comeUpWithItLater opened 3 years ago

comeUpWithItLater commented 3 years ago

Feature description:

Upgrade the helm chart to adopt the latest feature that jupyterhub offer , such as Customizing User Storage

Problem and motivation:

This will ensure that the latest feature in jupyterhub is always available in ml-hub.

Is this something you're interested in working on?

Yes, l'd love to . But I need some guideline on where to start.

ClementGautier commented 2 years ago

I was going to make some changes in the helm chart but saw that most of what I'm trying to solve is already fixed in https://github.com/jupyterhub/zero-to-jupyterhub-k8s/tree/main/jupyterhub

@raethlein : would you consider removing all jupyterhub related things from this repository and use the helm chart from jupyterhub as dependency?

raethlein commented 2 years ago

Hey @comeUpWithItLater and @ClementGautier, thanks for looking into this! I think using the official jupyterhub helm chart would be great as this would be one less dependency to care about. Back then I think the decision to copy the helm chart / parts of it to this repo was that we needed to make some slight modifications (e.g. setting some environment variables, opening another port for ssh access etc.) that was not directly configurable in the jupyterhub helm chart. I have to look into the newest helm chart version to see whether it could not be easily configured without the need to copy it here