ml-tooling / ml-hub

🧰 Multi-user development platform for machine learning teams. Simple to setup within minutes.
Apache License 2.0
301 stars 64 forks source link

Use new api for Ingresses #30

Closed ClementGautier closed 2 years ago

ClementGautier commented 2 years ago

What kind of change does this PR introduce?

Description: Fixes #29, Tested using kubeval:

helm template ./mlhub --set ingress.enabled=true | kubeval -v 1.22.4 -s  https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master

(I also tried to enable every other flags to see if it was compatible to not miss something but it seems the ingress was the only object impacted by the deprecations).

Checklist:

raethlein commented 2 years ago

Awesome, thank you very much @ClementGautier!