search

ml-tooling / ml-hub

🧰 Multi-user development platform for machine learning teams. Simple to setup within minutes.
Apache License 2.0
301 stars 64 forks source link

Helm chart configuration change doesn't trigger a pod restart #31

Closed ClementGautier closed 2 years ago

ClementGautier commented 2 years ago

Describe the bug:

Change the jupyterhub_config.py user configmap doesn't restart the hub pod, thus it doesn't apply the config change.

Expected behaviour:

Changing the userConfig value should be taken into account during helm upgrade

Steps to reproduce the issue:

helm install with a userConfig helm upgrade with another version of the userConfig see that the configuration isn't applied

Possible Fix:

adding the checksum annotation in the deployment template should fix the issue. I'll provide the pull request asap