ml-tsai / curved-corner

Automatically exported from code.google.com/p/curved-corner
0 stars 0 forks source link

IE8 generates "File does not exist" messages in apache log #45

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Access web page using border-radius.htc with IE8
2.
3.

What is the expected output? What do you see instead?
No messages in apache log

What version of the product are you using? On what operating system?
2009/11/18 from Nick Fetchak

Please provide any additional information below.
Something in the js code is resolving to "none" ?

Original issue reported on code.google.com by I.Thurlb...@gmail.com on 15 Jul 2010 at 10:59

GoogleCodeExporter commented 8 years ago
This seems to be because of the regular expression in line 44

var fillSrc = this.currentStyle.backgroundImage.replace(/^url\("(.+)"\)$/, 
'$1');

that might also return the string 'none' if the expression does not match.
In line 94 this string is assigned unfiltered as an option to the created 
Element of line 92.
If fillSrc is 'none' the browser requests a file / the uri called none.

I changed line 94 to the following.

(fillSrc != 'none') ? fill.src = fillSrc : fill.src = '';

The ternary operator. If fillSrc IS NOT EQUAL to 'none' then assign fillSrc to 
fill.src otherwise assign an empty string.

It works for me. Good luck!

Original comment by rsche...@gmail.com on 16 Jul 2010 at 12:56

GoogleCodeExporter commented 8 years ago
Feedback about whether it's working or not is very much appreciated by me and 
future visitors. The web never forgets. ;-)

Original comment by rsche...@gmail.com on 17 Jul 2010 at 8:54

GoogleCodeExporter commented 8 years ago
Yes, this fixes the problem.

Many thanks!

Original comment by I.Thurlb...@gmail.com on 21 Jul 2010 at 7:53

GoogleCodeExporter commented 8 years ago
Another confirmation that reschenke's fix in comment 1 fixes the problem.

Original comment by GuusBos...@gmail.com on 22 Nov 2010 at 6:24

GoogleCodeExporter commented 8 years ago
Please, fix this bug in trunk.

Patch works fine, thanks!

Original comment by sero...@gmail.com on 27 Nov 2010 at 10:13

GoogleCodeExporter commented 8 years ago
Patch works fine!

I tried:

if (fillSrc != 'none') { fill.src = fillSrc }

but has no luck. Only use as provided by rschenke ;)

Original comment by Sergey.C...@gmail.com on 9 Dec 2010 at 5:23