ml4ai / automates

AutoMATES: Automated Model Assembly from Text, Equations, and Software
https://ml4ai.github.io/automates
Other
25 stars 9 forks source link

Adding 'ghost test' for cast_to_pdf #211

Closed titomeister closed 3 years ago

titomeister commented 3 years ago

The 'ghost test' is a file I found in CAST2GrFN's tests called 'cast_all_nodes.json' which looks to have a good deal of the CAST nodes in the file. I think this is good enough to solve the coverage issues, but let me know and I could come up with something else. I wrote a test script that reads the JSON file, creates a pdf out of it, and then deletes the pdf. Then, the test passes by default.

codecov[bot] commented 3 years ago

Codecov Report

Merging #211 (071db0e) into master (1215866) will increase coverage by 1.85%. The diff coverage is 91.89%.

:exclamation: Current head 071db0e differs from pull request most recent head 661228c. Consider uploading reports for the commit 661228c to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   65.94%   67.79%   +1.85%     
==========================================
  Files          76       76              
  Lines       14131    14133       +2     
==========================================
+ Hits         9319     9582     +263     
+ Misses       4812     4551     -261     
Impacted Files Coverage Δ
...lysis/CAST2GrFN/visitors/cast_to_agraph_visitor.py 93.52% <91.54%> (+93.52%) :arrow_up:
automates/program_analysis/CAST2GrFN/cast.py 92.85% <100.00%> (+0.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1215866...661228c. Read the comment docs.