search

ml4ai / automates

AutoMATES: Automated Model Assembly from Text, Equations, and Software
https://ml4ai.github.io/automates
Other
25 stars 9 forks source link

small fix for processing attachments #229

Closed maxaalexeeva closed 3 years ago

maxaalexeeva commented 3 years ago

found by is only for context attachments

codecov[bot] commented 3 years ago

Codecov Report

Merging #229 (14b925b) into Alice_Function2 (643d61b) will decrease coverage by 0.66%. The diff coverage is 64.45%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           Alice_Function2     #229      +/-   ##
===================================================
- Coverage            68.40%   67.73%   -0.67%     
===================================================
  Files                   78       81       +3     
  Lines                14523    15138     +615     
===================================================
+ Hits                  9934    10254     +320     
- Misses                4589     4884     +295
Impacted Files Coverage Δ
...analysis/CAST2GrFN/visitors/cast_to_air_visitor.py 58.11% <ø> (-23.08%) :arrow_down:
automates/program_analysis/CAST2GrFN/cast.py 66.27% <29.41%> (-26.78%) :arrow_down:
...lysis/CAST2GrFN/visitors/cast_to_agraph_visitor.py 92.60% <55.55%> (-0.92%) :arrow_down:
...ates/program_analysis/PyAST2CAST/py_ast_to_cast.py 63.37% <63.37%> (ø)
...rogram_analysis/CAST2GrFN/model/cast/source_ref.py 74.68% <74.68%> (ø)
.../program_analysis/CAST2GrFN/model/cast/ast_node.py 53.48% <90.90%> (+12.31%) :arrow_up:
.../program_analysis/CAST2GrFN/model/cast/__init__.py 100.00% <100.00%> (ø)
...ates/program_analysis/CAST2GrFN/model/cast/name.py 63.26% <0.00%> (-22.45%) :arrow_down:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ba7c6e...14b925b. Read the comment docs.

alicekwak commented 3 years ago

@maxaalexeeva Thank you for the fix! It is correct that "foundBy" should only be used for context attachments. I'd like to merge this branch into Alice_Function2, but it seems like some checks are failing. Do you have any idea why these checks are not successful?

maxaalexeeva commented 3 years ago

Those are about code coverage. I don't think it matters right now because we're not merging into master. But if you'd like, you can just adjust the code in your branch like I did here instead of merging this and close this pr.

alicekwak commented 3 years ago

Thanks Masha! I just adjusted the code in my branch just in case. I'll close this PR now.