Debugging test t3f - Githubissues

ml4ai / automates

AutoMATES: Automated Model Assembly from Text, Equations, and Software

https://ml4ai.github.io/automates

Other

25 stars 9 forks source link

Debugging test t3f #271

Closed maxaalexeeva closed 2 years ago

maxaalexeeva commented 2 years ago

main change: drop Identifier label on an expanded Identifier mention---it is no longer just an identifier if we expand---this was what broke test t3f

other:

added det to invalid outgoing to one of new invalid outgoings---it was expanding to just the determiner;
set hops back to five;
remove 'foundBy' in toAttachment---key was not found because foundBy does not occur in all types of attachments, which broke align test

maxaalexeeva commented 2 years ago

@alicekwak it should be safe to merge this into your branch (even if tests fail here). I can walk you through the changes tomorrow or Wednesday if something is unclear.