ml4ai / automates

AutoMATES: Automated Model Assembly from Text, Equations, and Software
https://ml4ai.github.io/automates
Other
25 stars 9 forks source link

Unit and param men fix dec2021 #281

Closed maxaalexeeva closed 2 years ago

maxaalexeeva commented 2 years ago
alicekwak commented 2 years ago

Oops, and it looks like one ParameterSetting test (u5a) is failing. The test sentence is this:

For the purposes of model parameterisation the value of shoot_lag has been assumed to be around 40 o Cd.

It's failing because "value of shoot_lag" is captured as a variable instead of "shoot_lag". Do you have any idea why this change occurred?

maxaalexeeva commented 2 years ago

@alicekwak

It's failing because "value of shoot_lag" is captured as a variable instead of "shoot_lag".

Nooooo! That was one of those accidentally fixed tests and now it broke again because of who knows what! Bummer.

codecov[bot] commented 2 years ago

Codecov Report

Merging #281 (0233bad) into master (26d129b) will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   66.04%   66.02%   -0.02%     
==========================================
  Files          95       95              
  Lines       17892    17892              
==========================================
- Hits        11816    11814       -2     
- Misses       6076     6078       +2     
Impacted Files Coverage Δ
automates/model_analysis/graph_manipulation.py 70.19% <0.00%> (-0.56%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26d129b...0233bad. Read the comment docs.