search

ml4ai / automates

AutoMATES: Automated Model Assembly from Text, Equations, and Software
https://ml4ai.github.io/automates
Other
25 stars 9 forks source link

Python version inconsistency #334

Closed kwalcock closed 1 year ago

kwalcock commented 1 year ago

In environment.yml it says - python=3.7.9=h60c2a47_0 but in

setup.py it says python_requires=">=3.8"

which causes problems if both files are used.

cl4yton commented 1 year ago

Thanks @kwalcock, good catch. I created a branch for this issue: 334-python-version-inconsistency . Please go ahead and bump the environment.yml python to be >= 3.8 to match setup.py. Thanks!

vincentraymond-ua commented 1 year ago

@cl4yton - This is related to a discussion @titomeister and I had a while back, where we were wondering what Python version(s) we should target.

Currently, I believe there is Gromet code that requires at least Python 3.9. We had some Python 3.10 code at one point, but I think we converted it all down to Python 3.9 since that it what Tito is using.

cl4yton commented 1 year ago

Oh, got it! Then let's set the minimum python version in both setup.py and environment.yml to 3.9.

So rather than assigning this to @kwalcock , can you, @vincentraymond-ua , go ahead and make these changes in the 334-python-version-inconsistency and then PR?

vincentraymond-ua commented 1 year ago

@cl4yton - Sounds good, I will do that!