ml4ai / automates

AutoMATES: Automated Model Assembly from Text, Equations, and Software
https://ml4ai.github.io/automates
Other
25 stars 9 forks source link

Missing support for Window's path format in Gromet generation. #338

Open vincentraymond-ua opened 1 year ago

vincentraymond-ua commented 1 year ago

There are currently a couple of small bugs where inaccurate Gromet is generated if running the program analysis pipeline on a Windows machine. This is due to the differences in path format between MacOS/Linux and Windows.

These both can likely be fixed using the Python os module to handle paths when necessary.

Instance 1: The GrometFNModule "name" field.

 "modules": [
        {
            "schema": "FN",
            "schema_version": "0.1.4",
            "name": "C:\\Users\\Example\\AppData\\Local\\Temp\\tmpdpbxdnjh\\penn_chime\\cli",

Instance 2: The GrometFNModuleCollection "module_index" and "executables" fields

"module_index": [
        "penn_chime\\cli\n",
        "penn_chime\\constants\n",
        "penn_chime\\model\\parameters\n",
        "penn_chime\\model\\sir\n",
        "penn_chime\\model\\validators\\base\n",
        "penn_chime\\model\\validators\\validators\n"
    ],
"executables": [
    "penn_chime\\cli\n"
]

This likely can be fixed in multifile_ingester.py