search

ml4ai / delphi

Framework for assembling causal probabilistic models from text and software.
http://ml4ai.github.io/delphi
Apache License 2.0
24 stars 17 forks source link

Variables not found after _decision_ fix #464

Open pauldhein opened 4 years ago

pauldhein commented 4 years ago

Overview

I have found some bugs occurring when I try to run scripts/f2grfn_standalone.py in the dssat_pet branch after pulling @pratikbhd's changes to support the updated decision nodes. @pratikbhd can you take a look at these bugs and see if you can provide a quick-fix? I have added below the stack traces for two of the fortran files in our test data code that are failing to be processed. Let me know if you need any more information to solve this bug.

@skdebray I am adding you on this issue so that you can track the progress and conversation.

Stack-trace for mini_PET.for

Screen Shot 2020-04-27 at 9 30 42 AM

Stack-trace for SIR-Gillespie-SD.f

Screen Shot 2020-04-27 at 9 31 26 AM
pratikbhd commented 4 years ago

@pauldhein I fixed the issue appearing on SIR-Gillespie-SD.f but the one for mini_PET.for is a bit more involved and am still working on it. How early do you need these to be fixed?

pauldhein commented 4 years ago

Thanks for getting to work on this @pratikbhd! Now that SIR-Gillespie-SD.f is fixed I'm not nearly as blocked as I was before. Do you think it will be possible to have mini_PET.for fixed by our Monday meeting? That would be a workable time table for me.

pratikbhd commented 4 years ago

@pauldhein This has been implemented as per the recent push to the dssat_pet branch. Could you verify this from your end?