search

ml4ai / funman

SKEMA Functional Model Analysis (FUNMAN)
MIT License
2 stars 2 forks source link

Api #41

Closed danbryce closed 1 year ago

jgladwig commented 1 year ago

Looks like the pytest fails within the docker container due to openapi_python_client not having been installed. The dev container probably needs a RUN pip install --no-cache-dir openapi_python_client.

Once I fixed that manually I also see a pile of api related warnings popping up related to callable functions. For example:

test/test_api.py::TestAPI::test_api_consistency                                                                                                                                               
  /home/jladwig/funman_venv/lib/python3.8/site-packages/fastapi/openapi/utils.py:127: UserWarning: Callable function was excluded from schema since JSON schema has no equivalent type.       
    body_schema, _, _ = field_schema(

Are those something to be concerned about for expected functionality?

danbryce commented 1 year ago

Looks like the pytest fails within the docker container due to openapi_python_client not having been installed. The dev container probably needs a RUN pip install --no-cache-dir openapi_python_client.

Once I fixed that manually I also see a pile of api related warnings popping up related to callable functions. For example:

test/test_api.py::TestAPI::test_api_consistency                                                                                                                                               
  /home/jladwig/funman_venv/lib/python3.8/site-packages/fastapi/openapi/utils.py:127: UserWarning: Callable function was excluded from schema since JSON schema has no equivalent type.       
    body_schema, _, _ = field_schema(

Are those something to be concerned about for expected functionality?

I think this warnings are potentially benign. They are due to FastAPI not knowing how to serialize the objects. I don't intend to serialize them in their current form. I believe that we'll catch these by expanding the test_api.py to include more endpoints. I'm okay with it being in this state in the develop branch for now.