ml4ai / skema

SKEMA: Scientific Knowledge Extraction and Model Analysis
https://ml4ai.github.io/skema/
Other
10 stars 4 forks source link

Endpoint for counting objects in a gromet FN #557

Closed Free-Quarks closed 1 year ago

Free-Quarks commented 1 year ago

Add some endpoints to count objects in a gromet FN to allow for easier testing and development of tests for the code2amr pipeline.

vincentraymond-ua commented 1 year ago

@Free-Quarks - I'm working on creating an endpoint for this. Below is an example output I'm generating. Do you think these fields are adequate, or are there any additional fields you would want to add?

{'b': 7, 'bf': 9, 'opi': 1, 'opo': 3, 'pil': 0, 'pol': 0, 'wlopi': 0, 'wll': 0, 'wlf': 0, 'wlc': 0, 'wlopo': 0, 'pof': 7, 'pif': 3, 'wfopi': 1, 'wfl': 0, 'wff': 2, 'wfc': 0, 'wfopo': 3, 'pic': 0, 'poc': 0, 'wcopi': 0, 'wcl': 0, 'wcf': 0, 'wcc': 0, 'wcopo': 0}
Free-Quarks commented 1 year ago

Those look great! The only other possible field that came to mind, which is minor and not super necessary, would be if we could also have a field for an aggregate count of all the wires (just adding all the wiring fields together), since they aren't distinguished in the memgraph.

vincentraymond-ua commented 1 year ago

Update 10/10/2023

This is essentially complete, I just need to finish writing the unit test for the endpoint.

vincentraymond-ua commented 1 year ago

Update 10/13/2023

To be resolved by #574