search

ml4ai / tomcat

ToMCAT: Theory of Mind-based Cognitive Architecture for Teams
https://ml4ai.github.io/tomcat/
MIT License
21 stars 7 forks source link

Fixed the lagging behind of physio plots #443

Closed manujinda closed 2 years ago

manujinda commented 2 years ago

Now physio plots gets chunks of samples accumulated while plotting the previous sample and only plots the last sample of each chunk skipping all the samples it did not get to in time.

Did some code cleanup and rearrangement.

manujinda commented 2 years ago

I tried to create a pull request but was blocked as I am not authorized.

adarshp commented 2 years ago

@manujinda - it looks like the pull request was created. Did you mean that you were not able to merge the pull request into the master branch?

CalebUAz commented 2 years ago

@manujinda LGTM!

@paulosoaresua could you please invoke run_physio_viz.sh with the uberscript (after we launch labrecorder)?

Once that's done, @adarshp would merge it with the master.

paulosaurusrex commented 2 years ago

@CalebUAz I think this should be closed and another ticket added to incorporate this in the uber script. I understand that we can run this manually from CAT, so this PR should be done IMO.

CalebUAz commented 2 years ago

@CalebUAz I think this should be closed and another ticket added to incorporate this in the uber script. I understand that we can run this manually from CAT, so this PR should be done IMO.

Correct, we can execute this manually from CAT! In that case @adarshp you can please proceed and merge it with the master?

adarshp commented 2 years ago

@CalebUAz - done.