search

ml5js / ml5-data-and-models-server

A repo to download and serve data and models locally allowing ml5 to run without a web connection
29 stars 13 forks source link

fix: can not find SketchRnn on case-sensitive file system(linux) #10

Closed snowyu closed 2 years ago

tlsaeger commented 3 years ago

Hey @snowyu thanks for the PR, it is highly appreciated. Could you be so kind and write a little bit about the what exactly you are fixing and how. This will help us further down the line, to keep an overview. Thanks and have a good one!

snowyu commented 3 years ago 
# Can not work on linux(ext4 file system)
npm run download:all

ml5-data-and-models-server@0.0.1 download:all ~/ml5js/ml5-data-and-models-server
> node ./scripts/download-models/index.js all

internal/modules/cjs/loader.js:883
  throw err;
  ^

Error: Cannot find module './SketchRnn'
omar2205 commented 2 years ago

IDK why this PR wasn't accepted, the script thinks there is a dir SketchRnn in scripts/download-models But it's called SketchRNN

tlsaeger commented 2 years ago

Hi @omar2205 and @snowyu apologies for late reply. Need to ping @shiffman @bomanimc to approve this request. As I'm not that deep into the data-and-models-server project.

shiffman commented 2 years ago

Yes, this is great! Thank you so much for the contribution!!