ml5js / ml5-data-and-models

Data sets and pre-trained models for ml5.js
https://ml5js.org/docs/data-overview
MIT License
125 stars 98 forks source link

added face-api models #38

Closed joeyklee closed 3 years ago

joeyklee commented 5 years ago

Adds the face-api models from: https://github.com/justadudewhohacks/face-api.js?files=1

EKZERSIS commented 5 years ago

Super!

shiffman commented 3 years ago

@joeyklee Should I merge this and keep a copy of the face-api model here or have we changed how this process works?

joeyklee commented 3 years ago

Oh wow this is an old one! From ages ago actually. Mmm I think for now probably it's ok to add this in. I will merge now.

joeyklee commented 3 years ago

This whole repo isn't really being used or maintained, but we will likely need to figure out a better solution of storing models somewhere since keeping them in the git history will bloat this repo up!

shiffman commented 3 years ago

Indeed, however, I am using it now as a place to store example charRNN models for the IMA assignment this week!

bomanimc commented 3 years ago

It looks like we'll need to merge this into main to unbreak our FaceAPI model which is depending on the models in this branch: https://github.com/ml5js/ml5-library/blob/36a7ceafce4ccd31700c316b5beb32c862221a3c/src/FaceApi/index.js#L23

bomanimc commented 3 years ago

Opened issue https://github.com/ml5js/ml5-library/issues/1093 to come back and fix this. For now, to bypass having this be broken until we release again, I opened up another branch called face-api with the models files in it.