search

ml5js / ml5-library

Friendly machine learning for the web! 🤖
https://ml5js.org
Other
6.48k stars 902 forks source link

Tavis CI testing fails w/ node version >10 - include specific instructions? #263

Closed joeyklee closed 5 years ago

joeyklee commented 5 years ago

There were some issues with checking PRs and the CI. I thought it would be worth documenting and noting the fix for cases in which a PR does not pass the CI test as noted here: https://github.com/ml5js/ml5-library/pull/254#issuecomment-451720071

Steps:

  1. remove your node_modules
  2. npm install
  3. yarn install
  4. include your username and accessKey in the karma.conf.js 
    browserStack: {
  username: process.env.BROWSERSTACK_USERNAME,
  accessKey: process.env.BROWSERSTACK_ACCESS_KEY
},
  5. yarn test
  6. yarn test-travis
  7. commit your changes w/ yarn.lock and package.lock
  8. make your PR or commit your changes to your existing PR

Hope this helps / makes sense!

Thanks! 🙏

yining1023 commented 5 years ago

If you are on node version 10, the Travis test on your PR might fail.

To add to @joeyklee's suggestions: We need to delete package-lock.json & yarn.lock.json file & node_modules before running yarn install or npm install again.

joeyklee commented 5 years ago

Closing this issue now. Thanks!