search

ml5js / ml5-library

Friendly machine learning for the web! 🤖
https://ml5js.org
Other
6.46k stars 899 forks source link

Bug - LSTM text generation examples not working #317

Closed WilliamLehmus closed 5 years ago

WilliamLehmus commented 5 years ago

→ Description 📝

Just noticed the 'interactive text generation LSTM' example is not working currently. Checking in the console it throws the following error when loading the page:

edit Noticed the same goes for the 'Text Generation with LSTM' example. 

example-lstm-interactive.js:2 Uncaught TypeError: ml5.LSTMGenerator is not a function
    at example-lstm-interactive.js:2
(anonymous) @ example-lstm-interactive.js:2
example-lstm-interactive.js:16 Uncaught ReferenceError: textInput is not defined
    at setup (example-lstm-interactive.js:16)
    at e.<anonymous> (p5.min.js:32)
    at e.<anonymous> (p5.min.js:32)
    at new e (p5.min.js:32)
    at e (p5.min.js:32)

→ Helpful Information 🦄

Chrome version 72.0.3626.121 on Windows 10.

shiffman commented 5 years ago

Hi! Where are you looking at the example? One of the things we're trying to do is clean up a lot of the redundancies. LSTMGenerator was changed to charRNN so we must have missed one somewhere!

pbalogh commented 5 years ago

Ah, I was using the example here: https://ml5js.org/docs/lstm-example

shiffman commented 5 years ago

Thank you! I'm going to close this as we are tracking here: https://github.com/ml5js/ml5-website/issues/100 Thank you for highlighting this issue again!