ml5js / ml5-library

Friendly machine learning for the web! 🤖
https://ml5js.org
Other
6.46k stars 904 forks source link

KNN classifier save seems capped at around 4000 examples #405

Closed fartass closed 1 year ago

fartass commented 5 years ago

→ Description 📝

I either found a bug 🐛 or the KNN classifier save is capped at around 4000 examples intentionally.

→ Helpful Information 🦄

I am generating my own data for the KNN classifier by making new examples, knnClassifier.getCountByLabel(); holds more than 4000. But the save file stays about the same as before the new examples and the amount of examples are not increased when I load the new model.json. So it can only save 4000 examples perhaps?

sproutleaf commented 1 year ago

Closing this issue. Documentation will be updated correspondingly in https://github.com/ml5js/ml5-website/issues/193.