[charRNN & ml5 library] model loading in p5 web editor support

ml5js / ml5-library

Friendly machine learning for the web! 🤖

https://ml5js.org

Other

6.46k stars 899 forks source link

[charRNN & ml5 library] model loading in p5 web editor support #715

Closed joeyklee closed 3 years ago

joeyklee commented 4 years ago

Dear ml5 community,

I'm submitting a new issue. Please see the details below.

→ Step 1: Describe the issue 📝

Did you find a bug? Want to suggest an idea for feature?

bug / enhancement
Currently a lot of the ml5 models will break in the p5 web editor due to the way that files are loaded based on the "directory structure" and way that data is stored in the web editor.
We should try to make it consistent or at least flag that some features won't work in the web editor
related to: https://github.com/ml5js/ml5-examples/issues/247

cc/ @catarak

catarak commented 4 years ago

Are there also maybe ways to update the web editor to make this work? I know we had discussed this briefly but I can't remember all of the possibilities we talked about...

joeyklee commented 4 years ago

@catarak - happy to discuss. In the meantime, I will note down some of the ways we've addressed model loading and mark which features currently are not working.

Thank you!

bomanimc commented 3 years ago

Hi all! I addressed this temporarily by pointing the CharRNN examples to a hosted version of the model (#1186). That said, I'd be curious to know if there work other ideas that we discussed if folks still remember. In the short-term, I'm going to close this issue, but please reopen if you want to continue discussion!