search

ml5js / ml5-website-v01

ml5.js website
https://ml5js.org
MIT License
64 stars 45 forks source link

Description may be wrong in charRNN() > predict function #104

Open cabbage63 opened 5 years ago

cabbage63 commented 5 years ago

web: https://ml5js.org/docs/CharRNN#methods src: https://github.com/ml5js/ml5-website/blob/source/docs/api-charRNN.md

I have two point that may required to be fixed.

  1. method description

    Feed a string of characters to the model state. It's the same sentence as feed method. I suspect it may be not appropriate.

  2. Property name

    predict - Predict the next character based on the model's current state. I think It should be temperature. I'm sorry but I'm not sure whethre the content of description is right or not, because I don't know charRNN well.

Thank you.