Closed cvalenzuela closed 5 years ago
I added more docs over sketchRNN. For the KNN API changes I think we should open a new PR in the library.
Btw, the new "Apply Suggestion" is really nice!
We've (@joeyklee @yining1023 and I) have decided to merge this and publish it! Then we will open new issues and make new pull requests for anything we missed (like charRNN
name change.)
Noting that this worked and the new website is live! (I'll note that we had a website redesign discussion today during the working group meeting so thing will change, but technically the new examples and documentation are there!) Next steps:
charRNN
(will open new issue)0.2.1
(?) release?
Oh also, I should mention that I commented with some ideas to simplify / shorten the KNN API function names, etc.? But I don't feel strongly about this, if it's losing important terminology or less clear with my suggestions feel free to ignore!