search

ml5js / ml5-website-v02-docsify

This repository is a work-in-progress website, containing documentation and reference materials for the ml5.js library models.
https://docs.ml5js.org/
Other
1 stars 11 forks source link

Fix sidebar gap & add top margin #71

Closed alanvww closed 5 months ago

alanvww commented 7 months ago

Sorry for the re-formatting, please use "ignore whitespace" to review the changes.

The only changes I made are, 

topMargin: 30

line 66 in docs/index.html and,

margin: 57px 0 0 0;

line 211 in docs/css/style-markdown.css

Related issues #70 #68 #52

netlify[bot] commented 7 months ago

Deploy Preview for ml5-next-gen-docs ready!

Name Link
Latest commit bef5ddac8b56f025bc9cf07e8d4e2b3d2fa7e78b
Latest deploy log https://app.netlify.com/sites/ml5-next-gen-docs/deploys/6629cec3fd233900086560df
Deploy Preview https://deploy-preview-71--ml5-next-gen-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alanvww commented 7 months ago

Hi @alanvww, I just checked your commit, and seems you used some format tools that adjust the indentation. Could you please roll back to the existing format and only add the top margin code? Let me know if you need my help:)

Hi @QuinnHe ! Sorry for the formatting problem. I just rolled back the previous changes. Please check the latest commit and review the file change.

This commit didn't fix #68 .

MOQN commented 5 months ago

Thank you so much @alanvww for pointing out and for the PR! I applied margin-top: 3.5rem;, avoiding using pixel values.