Open RobbeSneyders opened 1 year ago
Building multi-arch images has nice benefits:
Downsides:
If it is only for local development (local runner on Mac's M1 chips) then I would just alter the docker-compose file to include the platform.
https://github.com/compose-spec/compose-spec/blob/master/spec.md#platform
The major clouds also offer ARM machines, especially Amazon it seems. Not sure how popular those are, but those would benefit from multi-arch images as well.
Since this might have an impact on image size as well, let's take https://github.com/ml6team/fondant/issues/573 into account and maybe tackle them together.
As a temporary fix we will add the:
export DOCKER_DEFAULT_PLATFORM=linux/amd64
on the fondant side. Until we are ready to build ARM images (with reasonable size)
Currently users who try to pull images on their M1 silicon (eg. using the local runner) will run into the following issue:
They can solve this by setting the
DOCKER_DEFAULT_PLATFORM
environment variable.This will instruct docker to pull images built for the
linux/amd64
platform instead. From the docker docs:I see different actions we can take with different levels of investment and return:
platform
flag / environment variable in the docker compose file when compiling the pipeline