Closed JonathanReeve closed 9 years ago
I mocked up what this might look like, with a centered primary/secondary tab nav:
I think this restructuring will require these sub-tasks:
/groups/my-groups/
, /groups/forums/
, /groups/committees/
, /groups/members-groups/
/groups/forums
, for instance, will load the group directory and filter appropriatelyAlternatively, I could just listen to GET requests on the group directory, and change the URLs to something like /groups?filter=forums
. This would be easier, but less pretty.
I think we have to go with easier but less-pretty URLs. For one, the hierarchy of /groups/[facet-name]/
conflicts with BP's hierarchy (/groups/[group-name]/
) and could lead to trouble—perhaps not with these URLs, but in future facets.
Oh, right. There is an "illegal group names" function somewhere, I think, that rejects certain reserved group names, but even with that, it's probably better not to interfere with this hierarchy. I'll just do the GET queries, then. I'll break this one out into the two sub-tasks.
Remove all filters, and replace them with these tabs:
Logged out:
Logged in:
"Forums" will be divisions and discussion groups. "Committees" will be committees, and "Members' Groups" will be everything else.
A related task will be to consolidate and rename divisions and discussion groups to "forums."
We will lose some functionality with this:
But I don't think the loss of (1) is too bad--group admins can find their groups in their "My Groups" tab. The loss of (2) isn't too bad, either, since actual membership size isn't effectively that important, compared to a group's activity. (3) can be solved by featuring new groups in a kind of carousel, and (4) isn't necessary, in my opinion.
We should probably keep this as an MLA-only modification, and not package it for upstream.