fix job import of project with whitespace

mlabouardy / butler

Export/Import Jenkins jobs & plugins 📤

MIT License

123 stars 34 forks source link

fix job import of project with whitespace #13

Open romainjacquet opened 5 years ago

romainjacquet commented 5 years ago

fix job import with a name containing whitespace by properly encode the url
display the HTTP error code in case of the import failed to help debugging

icereed commented 5 years ago

Good job! How did you test that?

romainjacquet commented 5 years ago

I have tested it during a migration of jobs that contains space at my office. Adding a test is not simple because for the moment, the function ImportJob has no test. I think that the commit is small enough to be checked without adding a test. What do you think?

icereed commented 5 years ago

I think it's a quite cool contribution, thank you! @mlabouardy would you like to merge this?

grootech commented 4 years ago

how can i import to jenkins which is working with my Gsuiute SSO ? it always says Unauthorized 401