Eliminate `HasPureRunner` typeclass

mlabs-haskell / apropos

Propositional Logic Apropos Types

Apache License 2.0

14 stars 5 forks source link

Closed AriFordsham closed 2 years ago

AriFordsham commented 2 years ago

Replace the HasPureRunner (Apropos.Pure) with a datatype:

data PureRunner p m = PureRunner
{ expect :: Formula p
, script   :: m -> Bool
}

Update the examples:
- Replace the HasPureRunner instances with (named) PureRunner objects
- Update calls to runPureTestsWhere
Update documentation

You may find draft PR #32 useful to get you started.

jhodgdev commented 2 years ago

Just to make it clear for the issue: this would allow multiple runners to be defined per module. Any other benefits, @AriFordsham ?

AriFordsham commented 2 years ago

That's the biggie. I feel it is cleaner, more idiomatic design, and easier to implement and use, but others may differ.

AriFordsham commented 2 years ago

Bonus points for coming up with a more descriptive name than PureRunner. maybe Model or similar?

jhodgdev commented 2 years ago

I always liked PureRunner. Sounded very cyberpunk IMO :joy: any suggestions @delicious-lemon @Geometer1729 ?